search

Lightning-AI / deep-learning-project-template

Pytorch Lightning code guideline for conferences
Apache License 2.0
1.24k stars 272 forks source link

Parameter hidden_dim unused #24

Open cheind opened 3 years ago

cheind commented 3 years ago

Hey,

I was just quickly browsing through the templates when I noticed that for the Autoencoder project the argparse parameter 'hidden_dim' is unused:

https://github.com/PyTorchLightning/deep-learning-project-template/blob/faef5bbf4f3c392b9e4d71e606edaab5ce4d0aaf/project/lit_autoencoder.py#L54

I suspect this should be used by the model to define the number of hidden dimensions. The other argparse parameter is probably accounted for in the Trainer (me: new to lightning). Thanks for this useful project.