Open tfogal opened 7 months ago
Quick update: I talked to the NeMo team and Eric had the (reasonable) concern that swapping in-place for out-of-place might increase memory consumption. The onus is on me to give it a try and look at the torch memory use with both in-place and out-of-place options; if the delta is minimal or nonexistent, we could do this.
I'll edit the issue as such.
🚀 Feature
NeMo's "Imagen" network implements text-to-image generation.
Initial
examine
:Motivation
Pitch
Work items
nan_to_num_
->nan_to_num
(out of place)add_
->add
(out of place)nan_to_num
instead of the in-place variantadd
instead of the in-place variantcc @tfogal