Lightning-AI / lightning-thunder

Make PyTorch models up to 40% faster! Thunder is a source to source compiler for PyTorch. It enables using different hardware executors at once; across one or thousands of GPUs.
Apache License 2.0
1.07k stars 60 forks source link

numpy 2.0.0 dtypes changes #610

Closed crcrpar closed 1 week ago

crcrpar commented 1 week ago

ref: https://numpy.org/devdocs/release/2.0.0-notes.html

crcrpar commented 1 week ago

some jobs e.g. https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=205694&view=logs&j=3f274fac-2e11-54ca-487e-194c91f3ae9f&t=7d9416f0-1669-5bc4-09c6-d0926f95334e&l=138 are affected.

crcrpar commented 1 week ago

it looks like fdm seems to depend on some archaic features of numpy: https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=205718&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f&j=3f274fac-2e11-54ca-487e-194c91f3ae9f&t=7d03ab59-8b52-555c-a216-77e14d28deec