Make PyTorch models up to 40% faster! Thunder is a source to source compiler for PyTorch. It enables using different hardware executors at once; across one or thousands of GPUs.
Apache License 2.0
1.07k
stars
60
forks
source link
Match torch signature for `torch.nn.functional.silu` #615
Before submitting
- [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
- [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section?
- [ ] Did you make sure to update the docs?
- [ ] Did you write any new necessary tests?
What does this PR do?
Matched the signature from torch documentation for torch.nn.functional.silu as discussed in a comment of #570. It's not the best idea to be able to pass the inplace argument without k-word but like this we match torch implementation signature.
Before submitting
- [x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? - [ ] Did you write any new necessary tests?What does this PR do?
Matched the signature from torch documentation for
torch.nn.functional.siluas discussed in a comment of #570. It's not the best idea to be able to pass theinplaceargument without k-word but like this we match torch implementation signature.