search

Lightning-AI / litgpt

Pretrain, finetune, deploy 20+ LLMs on your own data. Uses state-of-the-art techniques: flash attention, FSDP, 4-bit, LoRA, and more.
https://lightning.ai
Apache License 2.0
6.85k stars 726 forks source link

Only run expensive tests if code files change #1367

Closed rasbt closed 2 weeks ago

rasbt commented 2 weeks ago

Recently, we have been lots of small doc changes, and it's wasteful to run all the expensive tests if we change something in the markdown files like #1365 (also, waiting for those tests to pass is time consuming).

With the following modification, to the best of my knowledge, the tests would only run if any of the code files are changed. What do you think @carmocca @lantiga @awaelchli ?

carmocca commented 2 weeks ago

My opinion is that I wouldn't do this until the repository becomes more complex or has a lot of contributors without merge permissions. Today you can ignore CI if only markdown is modified. CPU tests are free and GPU tests run quickly.

rasbt commented 2 weeks ago

Hm that's weird that it doesn't work here, in my other repositories it works just fine. Perhaps it's somehow interacting with the tooling your mentioned. Let's not do this then.

carmocca commented 2 weeks ago

You probably don't have "required status checks" configured in those repositories.

We could also remove those to have this work if we disable auto-merge and trust people-who-merge to check CI status