Lightning-AI / torchmetrics

Torchmetrics - Machine learning metrics for distributed, scalable PyTorch applications.
https://lightning.ai/docs/torchmetrics/
Apache License 2.0
2.08k stars 400 forks source link

Add Bleu score #352

Closed SkafteNicki closed 3 years ago

SkafteNicki commented 3 years ago

🚀 Feature

Motivation

Add Blue score to future NLP package:

Pitch

Alternatives

Additional context

After merge to torchmetrics + official release the metric should be deprecated from flash + lightning-transformer.

github-actions[bot] commented 3 years ago

Hi! thanks for your contribution!, great first issue!

karthikrangasai commented 3 years ago

@SkafteNicki I would like to work on this issue.

I have moved the file functional/nlp.py to functional/text/blue.py. Where should I put the class implementation ??

SkafteNicki commented 3 years ago

Hi @karthikrangasai, Please put the class implementation in a new folder text inside a file called bleu

karthikrangasai commented 3 years ago

@SkafteNicki I have created a PR with the changes suggested.

I think tests and docs have to be updated, could you guide me on this ?