req: shift defaults to parent

Lightning-AI / tutorials

Collection of Pytorch lightning tutorial form as rich scripts automatically transformed to ipython notebooks.

https://lightning-ai.github.io/tutorials

Apache License 2.0

290 stars 83 forks source link

req: shift defaults to parent #338

Closed Borda closed 4 months ago

Borda commented 4 months ago

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?

move default requirements to the book's root

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70%. Comparing base (49d57e9) to head (da3cb05).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #338 +/- ## =================================== Coverage 70% 70% =================================== Files 2 2 Lines 413 413 =================================== Hits 291 291 Misses 122 122 ```