search

Lightning-AI / utilities

Common Python utilities and GitHub Actions in Lightning Ecosystem
Apache License 2.0
51 stars 16 forks source link

Avoid accidental namedtuple conversion in `apply_to_collection` #210

Closed GdoongMathew closed 10 months ago

GdoongMathew commented 10 months ago
Before submitting - [x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [x] Did you read the [contributor guideline](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md), Pull Request section? - Did you make sure to update the docs? - [x] Did all existing and newly added tests pass locally?

What does this PR do?

Fixes #196 fixes #206

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

📚 Documentation preview 📚: https://lit-utilities--210.org.readthedocs.build/en/210/

artbataev commented 10 months ago

@GdoongMathew can you also please add a test with a named tuple?

GdoongMathew commented 10 months ago

Hi, @artbataev namedtuple test case has been added. Thanks.

artbataev commented 10 months ago

@GdoongMathew, @carmocca thanks a lot!