search

Lightning-AI / utilities

Common Python utilities and GitHub Actions in Lightning Ecosystem
Apache License 2.0
49 stars 14 forks source link

docs: do not replace link for self #245

Closed Borda closed 5 months ago

Borda commented 5 months ago
Before submitting - [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md), Pull Request section? - Did you make sure to update the docs? - [ ] Did all existing and newly added tests pass locally?

What does this PR do?

debugging https://readthedocs.org/projects/lit-utilities/builds/23859566/ seems like https://pytorch.org/docs/stable/objects.inv is not the same as https://pytorch.org/docs/1.26/objects.inv even this is the latest at this time

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

📚 Documentation preview 📚: https://lit-utilities--245.org.readthedocs.build/en/245/

Borda commented 5 months ago

interesting that the build does not have any separation between PR and normal run but in PR ut does not replace stable even on the main branch it does... :/

Borda commented 5 months ago

even running with hardcoded 1.26 it passed https://readthedocs.org/projects/lit-utilities/builds/23861642/