When we replaced the deprecated pkg_resources version parsing in #281, we replaced the version comparison. The previous way implicitly handled pre-release version specifications, like 1.10.0.dev0+931b44f for example. This functionality got accidentally lost (but wasn't tested before). This PR restores this so that we don't break version parsing. The added test fails on main.
Borda
commented
1 month ago
When we replaced the deprecated
pkg_resourcesversion parsing in #281, we replaced the version comparison. The previous way implicitly handled pre-release version specifications, like1.10.0.dev0+931b44ffor example. This functionality got accidentally lost (but wasn't tested before). This PR restores this so that we don't break version parsing. The added test fails on main.Raised in https://github.com/Lightning-AI/lightning-thunder/issues/809
📚 Documentation preview 📚: https://lit-utilities--292.org.readthedocs.build/en/292/