Fixed: `Date` Display in Payment History Card on Profile Page

aliraza556 commented 1 month ago

Problem:

The dates on the payment history are being displayed incorrectly on the profile page. The current format does not properly handle the data returned from the /api/history endpoint.

Issue ticket number and link:

Ticket Number: [ 9 ]
Link: [ https://github.com/Lightning-Bounties/lb-next/issues/9 ]

closes #9

Evidence:

Acceptance Criteria

[x] Correct date format is displayed in the Payment History card.
[x] Dates align with data from the /api/history endpoint.
[x] Tested for accuracy with valid and edge-case data.

aliraza556 commented 1 month ago

Hi @sutt, @lb-founders,

Please review this PR.

sutt commented 1 month ago

@aliraza556 Looks great, thanks for your help. I added a small change to get it to work on PaymentsCard.

Check out the instructions for claiming the sats.

Hope to see you racking up more bounties soon.

aliraza556 commented 1 month ago

@aliraza556 Looks great, thanks for your help. I added a small change to get it to work on PaymentsCard.

Check out the instructions for claiming the sats.

Hope to see you racking up more bounties soon.

@sutt, Ok Thanks!

aliraza556 commented 1 month ago

Hi @sutt, when I added the PR number in the box and pressed 'Check,' I received an error 400.

sutt commented 1 month ago

@aliraza556 I see what went wrong....

By me adding a comment to this thread after the merge, I am breaking some server-side asserts on integrity checks of the PR.

Problems on our end, we'll get that fixed up by first thing tomorrow so you can claim the reward.

aliraza556 commented 1 month ago

@sutt, Thanks for the clarification! No worries, I appreciate the quick follow-up and effort to fix it. Looking forward to the resolution tomorrow. Let me know if there’s anything else I can help with. 😊

sutt commented 1 month ago

@aliraza556 Sorry for the delays, but you are officially the bounty winner on the app and you should have the sats in your profile.

Workarounds:

We discovered two issues with the business logic of our API that prevented this bounty from being awarded automatically. These weren't your error but ours, but listing them below for you so you can adapt until we can put in a patch to our API:

on PR message write closes #N or close #N. Don't add the colon, so don't say closes: #N
on the PR thread, don't add any comments after the PR has been merged. Feel free to add comments on the issue itself and "@" me though.

Other Open Bounties:

15 looks excellent, merging it in the next 10 minutes. I've already edited the PR message to remove the colon. So once it's merged you should be able to run "Claim Reward" and it should work 🤞. Of course ping me if it doesn't.
11 preview image looks like what we need. Feel free to submit as a PR and just remember to remove the colon from the "close #N" in the PR message.

Thanks for your great work and patience🙌.

aliraza556 commented 1 month ago

Hi @sutt, when I added the PR number in the box and pressed 'Check,' I received an error 400.

@sutt I get same error with #15 PR

aliraza556 commented 1 month ago

@sutt, Please see:

willbountyhunter commented 1 month ago

@aliraza556 Bounty awarded, sats should be in your profile

Thanks for your patience, we're just getting started and hope this runs much smoother soon.

aliraza556 commented 1 month ago

@aliraza556 Bounty awarded, sats should be in your profile

Thanks for your patience, we're just getting started and hope this runs much smoother soon.

@willbountyhunter, Thanks

Lightning-Bounties / lb-next