search

Lightning-Flow-Scanner / lightning-flow-scanner-core

A rule engine capable of conducting static analysis on the metadata associated with Salesforce Lightning Flows, Process Builders, and Workflows.
https://www.npmjs.com/package/lightning-flow-scanner-core
MIT License
27 stars 9 forks source link

False positive DMLStatementInLoop #86

Closed jdayment closed 5 months ago

jdayment commented 5 months ago

I started a new project and downloaded the flows into a new folder when running the scan I get a false positive for DML Inside Loop on any flow that includes a loop and assignment it seems that scan resulted in 501 of the 640 flows in the org having a DML Inside Loop. Other results are accurate i.e. SOQL in Loop. On Windows 11 in VSCODE

RubenHalman commented 5 months ago

@jdayment what solution are you using?

jdayment commented 5 months ago

@RubenHalman I am using the Lightning Flow Scanner VSCODE Extension v3.14.0

nvuillam commented 5 months ago

oops didn't want to close the issue, just to reference it from a commit on another repo ^^

RubenHalman commented 5 months ago

@nvuillam and @jdayment I believe this issue was present in both sfdx and vsce, but should be resolved with our latest version thanks to input from @patrykacc Please let me know if this issue remains

jdayment commented 5 months ago

@RubenHalman Looks like it's fixed on my end thanks @patrykacc!

RubenHalman commented 5 months ago

Thank you, @jdayment, @nvuillam & @patrykacc for providing the necessary feedback and help! I will close this issue, but please feel free to let us know if anything!