search

Lightning-Universe / lightning-Covid19

Classification for covid-19 chest X-ray images using Lightning
https://pytorchlightning.github.io/lightning-Covid19
MIT License
56 stars 18 forks source link

Feat/augmentation #18

Closed edgarriba closed 4 years ago

edgarriba commented 4 years ago

This PR adds an initial proposal for data augmentation

depends off https://github.com/PyTorchLightning/lightning-Covid19/pull/17

pep8speaks commented 4 years ago

Hello @edgarriba! Thanks for updating this PR.

Line 23:23: E262 inline comment should start with '# '

Comment last updated at 2020-03-29 11:34:22 UTC
oplatek commented 4 years ago

Hi @edgarriba, can you pls fix the pep8/flake8 errors?

oplatek commented 4 years ago

@edgarriba LGTM -> I will merge

Note: the Travis was not passing except because of this minor problem https://travis-ci.org/github/PyTorchLightning/lightning-Covid19/jobs/668325985#L329 @edgarriba do not worry about it, I will fix it in the master branch.

@Borda questions about ^: How can I collaborate on MR with the author and help him fixing such simple stuff if I cannot push to edgarriba:feat/augmentation?

edgarriba commented 4 years ago

@oplatek you can rebase author PR, modify and then push/merge

Borda commented 4 years ago

In PR you can use suggestions which can be simply merged from web UI or edit comple file which is part of the PR also in web UI =)