search

Lightning-Universe / lightning-flash

Your PyTorch AI Factory - Flash enables you to easily configure and run complex AI recipes for over 15 tasks across 7 data domains
https://lightning-flash.readthedocs.io
Apache License 2.0
1.74k stars 212 forks source link

Support for pytorch 1.13 #1502

Open benjats07 opened 1 year ago

benjats07 commented 1 year ago

🚀 Feature

Support for pytorch 1.13 and MPS

Motivation

I can't take advantage of MPS in macOS since is a recently added feature and lightning-flash didn't allow usage above torch 1.10

Alternatives

I already make config changes to force the installation with newer torch and torchvision versions, but seems that 'nms' isn't available on torchvision.ops.boxes and icevision request that.

Borda commented 1 year ago

lightning-flash didn't allow usage above torch 1.10

I don't this it is an issue with Flash, as you can see our dependencies... :rabbit: https://github.com/Lightning-AI/lightning-flash/blob/1e3395fe35014b997b97a59df9f8b24e0f272d1e/requirements.txt#L4 but it could come from other 3rd-party depenecy we rely on... :thinking:

Said so what is your use-case and how are you installing Flash? :otter:

benjats07 commented 1 year ago

I want to train models using MPS acceleration on MacOS but this capability is only available on lastest version of Pytorch. Especifically I want to follow this https://lightning-flash.readthedocs.io/en/latest/reference/object_detection.html

Borda commented 1 year ago

You can try to force upgrade Torch; I think all shall be working fine...