resolving tabular task & test serve

Borda commented 1 year ago

What does this PR do?

Trying to debug the Tab task, the main question is about embedded_cat_dim

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +10.67 :tada:

Comparison is base (5c42e23) 73.02% compared to head (56cac6b) 83.70%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1551 +/- ## =========================================== + Coverage 73.02% 83.70% +10.67% =========================================== Files 291 291 Lines 12957 12960 +3 =========================================== + Hits 9462 10848 +1386 + Misses 3495 2112 -1383 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `83.70% <ø> (+10.67%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. [see 58 files with indirect coverage changes](https://app.codecov.io/gh/Lightning-Universe/lightning-flash/pull/1551/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Borda commented 1 year ago

checking the serve issue with https://stackoverflow.com/a/50297147/4521646

Lightning-Universe / lightning-flash