Lightning-Universe / lightning-flash

Your PyTorch AI Factory - Flash enables you to easily configure and run complex AI recipes for over 15 tasks across 7 data domains
https://lightning-flash.readthedocs.io
Apache License 2.0
1.74k stars 213 forks source link

Update jsonargparse[signatures] requirement from <=4.9.0,>4.0.0 to >4.0.0,<=4.21.1 in /requirements #1564

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Updates the requirements on jsonargparse[signatures] to permit the latest version.

Changelog

Sourced from jsonargparse[signatures]'s changelog.

v4.21.1 (2023-05-09)

Fixed ^^^^^

  • AST resolver not working for dict used in a method when the dict is created using the curly braces syntax.
  • Failure on multiple deep arguments linked on instantiation ([#275](https://github.com/omni-us/jsonargparse/issues/275) <https://github.com/omni-us/jsonargparse/issues/275>__).

v4.21.0 (2023-04-21)

Added ^^^^^

  • Support for dataclasses nested in a type ([#243](https://github.com/omni-us/jsonargparse/issues/243) <https://github.com/omni-us/jsonargparse/issues/243>__).
  • Support for pydantic models <https://docs.pydantic.dev/usage/models/>__ and attrs define <https://www.attrs.org/en/stable/examples.html>__ similar to dataclasses.
  • Support for pydantic types <https://docs.pydantic.dev/usage/types/#pydantic-types>__.
  • Backport type stubs in python<=3.9 to support PEP 585 <https://peps.python.org/pep-0585/>__ and 604 <https://peps.python.org/pep-0604/>__ syntax.

Fixed ^^^^^

  • str parameter in subclass incorrectly parsed as dict with implicit null value ([#262](https://github.com/omni-us/jsonargparse/issues/262) <https://github.com/omni-us/jsonargparse/issues/262>__).
  • Wrong error indentation for subclass in union (lightning#17254 <https://github.com/Lightning-AI/lightning/issues/17254>__).
  • dataclass from pydantic not working ([#100](https://github.com/omni-us/jsonargparse/issues/100) comment <https://github.com/omni-us/jsonargparse/issues/100#issuecomment-1408413796>__).
  • add_dataclass_arguments not forwarding sub_configs parameter.
  • Failure to instantiate nested class group without arguments (lightning#17263 <https://github.com/Lightning-AI/lightning/issues/17263>__).

Changed ^^^^^^^

  • Switched from setup.cfg to pyproject.toml for configuration.
  • Removed build_sphinx from setup.py and documented how to build.
  • Include enum members in error when invalid value is given (lightning#17247 <https://github.com/Lightning-AI/lightning/issues/17247>__).
  • The signatures extras now installs the typing-extensions package on python<=3.9.
  • CLI now when given a class without methods, the class instance is returned.

... (truncated)

Commits
  • 0942fb9 Bump version: 4.21.0 → 4.21.1
  • 677a0f9 [pre-commit.ci] auto fixes from pre-commit.com hooks
  • 37e9cbf Refactored util tests using pytest.
  • f3f74d1 adding black formatting (#279)
  • 1c303a6 Fixed failure on multiple deep arguments linked on instantiation (#275).
  • d7e6dde add Ruff as code check (#280)
  • 8d57577 Refactored loaders_dumpers, namespace and optionals tests using pytest.
  • 54bf840 Refactored formatters, jsonschema and jsonnet tests using pytest.
  • 0805435 Refactored actions, argcomplete and cli tests using pytest.
  • 9039750 Removed some unittest specific code.
  • Additional commits viewable in compare view


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Borda commented 1 year ago

@dependabot rebase

codecov[bot] commented 1 year ago

Codecov Report

Merging #1564 (0f0bde6) into master (84e5e1d) will decrease coverage by 18%. The diff coverage is 100%.

:exclamation: Current head 0f0bde6 differs from pull request most recent head 340d57c. Consider uploading reports for the commit 340d57c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1564 +/- ## ======================================== - Coverage 86% 68% -18% ======================================== Files 291 291 Lines 12874 12865 -9 ======================================== - Hits 11011 8731 -2280 - Misses 1863 4134 +2271 ```
Borda commented 1 year ago

@mauvilsa could you pls advise how best to resolve this issue in the latest jsonargparse? :rabbit:

dependabot[bot] commented 1 year ago

A newer version of jsonargparse[signatures] exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.