Fixes issues identified in #1564. More generally, this pull request changes flash_cli.py and lightning_cli.py such that they only use jsonargparse's public API.
closes #1564
Before submitting
[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?
PR review
[x] Is this pull request ready for review? (if not, please submit in draft mode)
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
What does this PR do?
Fixes issues identified in #1564. More generally, this pull request changes
flash_cli.py
andlightning_cli.py
such that they only use jsonargparse's public API.closes #1564
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃