Lightning-Universe / lightning-flash

Your PyTorch AI Factory - Flash enables you to easily configure and run complex AI recipes for over 15 tasks across 7 data domains
https://lightning-flash.readthedocs.io
Apache License 2.0
1.74k stars 212 forks source link

Fix use of jsonargparse avoiding reliance on non-public internal logic #1620

Closed mauvilsa closed 1 year ago

mauvilsa commented 1 year ago

What does this PR do?

Fixes issues identified in #1564. More generally, this pull request changes flash_cli.py and lightning_cli.py such that they only use jsonargparse's public API.

closes #1564

Before submitting

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov[bot] commented 1 year ago

Codecov Report

Merging #1620 (ed74d4c) into master (30bf0f5) will decrease coverage by 0%. The diff coverage is 50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1620 +/- ## ====================================== - Coverage 86% 85% -0% ====================================== Files 291 291 Lines 12876 12867 -9 ====================================== - Hits 11013 10990 -23 - Misses 1863 1877 +14 ```
Borda commented 1 year ago

@mauvilsa awesome, thank you!