Lightning-Universe / lightning-flash

Your PyTorch AI Factory - Flash enables you to easily configure and run complex AI recipes for over 15 tasks across 7 data domains
https://lightning-flash.readthedocs.io
Apache License 2.0
1.74k stars 213 forks source link

Remove the restriction of Bert Based models in TextClassification Task. #294

Closed Atharva-Phatak closed 3 years ago

Atharva-Phatak commented 3 years ago

🚀 Feature

Remove the restriction of Bert Based models in TextClassification Task.

Motivation

For classification I would like to use flash but I want independence to differ from bert based models.

Pitch

Note: This goes without saying, I would like to work on a PR if this issue is accepted. 😃

edgarriba commented 3 years ago

@Atharva-Phatak what you mention makes total sense. Before asking you to send a PR - I would suggest to check this active PR about adding a token_classification task and add some comments there. See: https://github.com/PyTorchLightning/lightning-flash/pull/275

Atharva-Phatak commented 3 years ago

@edgarriba Thank you very much I will go through the mentioned PR.

Atharva-Phatak commented 3 years ago

@edgarriba I did take a look at #275, it seems with the new release the branch is outdated. So what should I do now ? Should I create a PR for this issue ?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.