search

Lightning-Universe / lightning-transformers

Flexible components pairing 🤗 Transformers with :zap: Pytorch Lightning
https://lightning-transformers.readthedocs.io
Apache License 2.0
610 stars 77 forks source link

change cfg.logger->cfg.trainer.logger #157

Closed JunnYu closed 3 years ago

JunnYu commented 3 years ago

change cfg.logger->cfg.trainer.logger cfg.trainer.logger's type is bool should return directly

codecov[bot] commented 3 years ago

Codecov Report

Merging #157 (59ad6be) into master (b1f4ae7) will decrease coverage by 0.12%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   84.73%   84.60%   -0.13%     
==========================================
  Files          66       66              
  Lines        1395     1397       +2     
==========================================
  Hits         1182     1182              
- Misses        213      215       +2
Flag Coverage Δ
unittests 84.60% <0.00%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lightning_transformers/core/instantiator.py 75.92% <0.00%> (-2.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1f4ae7...59ad6be. Read the comment docs.

SeanNaren commented 3 years ago

Thanks! Eventually we should allow the logger to be a instantiated object :)