karthikrangasai commented 3 years ago

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?

Fixes #194 .

Did you have fun?

Make sure you had fun coding 🙃

codecov[bot] commented 3 years ago

Codecov Report

Merging #195 (11b7594) into master (5aa7294) will decrease coverage by 0.95%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   87.27%   86.31%   -0.96%     
==========================================
  Files          73       70       -3     
  Lines        1658     1542     -116     
==========================================
- Hits         1447     1331     -116     
  Misses        211      211

Flag	Coverage Δ
unittests	`86.31% <100.00%> (-0.96%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ning_transformers/task/nlp/summarization/config.py	`100.00% <ø> (ø)`
...tning_transformers/task/nlp/summarization/model.py	`100.00% <100.00%> (ø)`
...ghtning_transformers/task/nlp/translation/model.py	`75.00% <100.00%> (+0.92%)`	:arrow_up:
...lp/question_answering/datasets/squad/processing.py	`83.44% <0.00%> (-0.69%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5aa7294...11b7594. Read the comment docs.

karthikrangasai commented 3 years ago

All the 4 failing tests are from the transformers library's generate function.

I am not sure why this is happening, any leads regarding this would be helpful.

Borda commented 2 years ago

@SeanNaren seems something went wrong with the minimal configuration...

mergify[bot] commented 2 years ago

This pull request is now in conflict... :(