search

Lightning-Universe / lightning-transformers

Flexible components pairing 🤗 Transformers with :zap: Pytorch Lightning
https://lightning-transformers.readthedocs.io
Apache License 2.0
607 stars 77 forks source link

import TransformerDataConfig from core.config #227

Closed bzantium closed 2 years ago

bzantium commented 2 years ago

It is natural to import TransformerDataConfig from core.config not core.data (even though TransformerDataConfig is imported in the script)

codecov[bot] commented 2 years ago

Codecov Report

Merging #227 (2b1bd65) into master (ff4f3e8) will increase coverage by 12%. The diff coverage is 100%.

:exclamation: Current head 2b1bd65 differs from pull request most recent head 1e8f7c6. Consider uploading reports for the commit 1e8f7c6 to get more accurate results

@@          Coverage Diff           @@
##           master   #227    +/-   ##
======================================
+ Coverage      74%    86%   +12%     
======================================
  Files          73     70     -3     
  Lines        1568   1557    -11     
======================================
+ Hits         1163   1340   +177     
+ Misses        405    217   -188
SeanNaren commented 2 years ago

I think because of the new refactor, this has already been resolved :)