Lightning-Universe / lightning-transformers

Flexible components pairing 🤗 Transformers with :zap: Pytorch Lightning
https://lightning-transformers.readthedocs.io
Apache License 2.0
607 stars 77 forks source link

Logger instantiation #232

Closed pietrolesci closed 2 years ago

pietrolesci commented 2 years ago

https://github.com/PyTorchLightning/lightning-transformers/blob/aa8f48addc9d16733cfb7572cf19cba17cad29a6/lightning_transformers/core/instantiator.py#L105

Hi there,

I think the above line is the cause of not seeing the logger even when requesting it with

 python train.py task=nlp/summarization dataset=nlp/summarization/xsum +trainer/logger=wandb

Maybe change to:

if cfg["trainer"].get("logger"):
    ...
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.