Lightning-Universe / lightning-transformers

Flexible components pairing 🤗 Transformers with :zap: Pytorch Lightning

https://lightning-transformers.readthedocs.io

Apache License 2.0

607 stars 77 forks source link

Refractor the code for model creation #268

Closed espoirMur closed 2 years ago

espoirMur commented 2 years ago

This refractor the code for model creation to make it overwritable.

PS: I haven't tested it yet but I am sure it will work..

WIP.

codecov[bot] commented 2 years ago

Codecov Report

Merging #268 (f48ba80) into master (7c691e7) will increase coverage by 0%. The diff coverage is 78%.

@@          Coverage Diff          @@
##           master   #268   +/-   ##
=====================================
  Coverage      74%    74%           
=====================================
  Files          62     62           
  Lines        1450   1455    +5     
=====================================
+ Hits         1070   1075    +5     
  Misses        380    380

SeanNaren commented 2 years ago

Appreciate the PR man!

EDIT: will wait for you to give the all clear :)

espoirMur commented 2 years ago

It is all clear , now .. everything is okay , for the issue.

SeanNaren commented 2 years ago

Thanks @espoirMur!