Lightning-Universe / lightning-transformers

Flexible components pairing 🤗 Transformers with :zap: Pytorch Lightning

https://lightning-transformers.readthedocs.io

Apache License 2.0

607 stars 77 forks source link

Update PyPI release trigger #302

Closed akihironitta closed 1 year ago

akihironitta commented 1 year ago

The PyPI release workflow wasn't triggered by the release event type as reported by @rohitgr7. The exact reason is still unknown, but it could be due to types: [created]. This PR updates the trigger so that it all aligns across our repositories' settings.

See the workflow file in our repo: https://github.com/Lightning-AI/lightning/blob/4750e221d1e7622bbf2d0e5b09e7136032e9c410/.github/workflows/release-pypi.yml#L8

codecov[bot] commented 1 year ago

Codecov Report

Merging #302 (61be366) into master (b6142fe) will not change coverage. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #302 +/- ## ===================================== Coverage 74% 74% ===================================== Files 63 63 Lines 1462 1462 ===================================== Hits 1086 1086 Misses 376 376 ```

Borda commented 1 year ago

manually publish when we release PL, or utilities

Utils were always automated, and PL for a while had not implemented the multi-package flow as it has been done since 1.8