LightsHope / issues

48 stars 22 forks source link

Hunter Ranged Critical Chance Varies depending on the type of melee weapon used. #859

Open Sylvatir opened 6 years ago

Sylvatir commented 6 years ago

How to reproduce: When I equip a fishing pole my ranged critical strike chance goes up by several %. Same thing happens when I equip a skinning knife, but about ½ a % lower than the fishing pole. Depending on the weapon I use my ranged critical strike chance is affected, I ran into an issue where I was equipping a polearm with 11 agility and my ranged critical strike chance was lower than with a staff, which had no agility and which I had a lower weapon skill on.

Godmatik commented 6 years ago

The crit chance number in the spellbook is not your actual ranged critical chance. The number shown there goes based on your melee weapon skill. Your actual crit chance for ranged weapons does not change.

Sylvatir commented 6 years ago

I did a damage meter check on it with 0% and yes, it does change.

Sylvatir commented 6 years ago

Can't you just equip a fishing pole or a skinning knife in combat and see how it changes yourself. I told you how to replicate the buff and right now I get a 7% increase in crit using a fishing pole. This is broken.

Sylvatir commented 6 years ago

Update: The ranged critical chance is reset to 0%+talents in combat once a buff or a debuff on the player is applied. You gain the crit chance back by swapping weapons again. You also get the bonus by not wearing any weapon, but you need a weapon to cycle it after it resets.

GuybrushGit commented 6 years ago

How are you checking your ranged crit chance? Tested with staff and polearm with different weapon skills, none have any effect on ranged crit. Only the stats on the weapon affected it, agility increased crit as expected.

Sylvatir commented 6 years ago

By doing damage to enemies around my level for about an hour with each weapon. The staff and polearm I only noticed from the toolip, so they can be amounted to statistical error. The fishing pole/skinning knife swapping is the real game changer, as you can clearly notice your amount of crits skyrocketing if you bother to keep swapping constantly with your primary melee weapon.

I'm sorry to say I do not have the mental resources to keep monitoring and reporting this for around 10000 hits and I would rather enjoy the game. I will most likely look into it with depth once I hit 60, if the bug still exists at that level.

Sylvatir commented 6 years ago

The crit increase in tooltip happened by removing weapons altogether until I leveled unarmed over 100. Maybe there's a math error somewhere?

GuybrushGit commented 6 years ago

That is an incredibly flawed way to test it. Its much more accurate and fast to run the core locally and check the internal values.

I couldn't reproduce any ranged crit change. The tooltip is for melee crit only and it will change depending on how much skill you have with your current melee weapon.