Open longquan7 opened 6 years ago
As far as I know, to make it available from https://hub.docker.com/u/arm64v8/ it is required to update the official definition file, but we'll do that in the next few weeks when Lightstreamer 7 will be officially released.
@gfinocchiaro we have managed to build and run Lightstreamer on ARM64v8 with no issues.
Would it be okay to enable this project so that it's docker pull
able on our systems please?
If you need help, I would be happy to provide a Pull Request for you.
Hi,
do you have a link from which I can view the definition file?
THIS is the file that needs changing.
Again, I'm happy to do it for you if you'd support it.
Ok, thanks. Does the Dockerfile needs any specific update?
The current Dockerfile 'just worked' on our ARM64v8 platform.
No other changes are required to support it.
May I ask you for which kind of devices are you planning to run the Lightstreamer Docker image?
I am currently testing it on an Enterprise level (64-cores, 256GB RAM, etc) platform.
Ok, feel free to make a PR.
Okay, all done. Please feel free to review and/or provide your Ack.
@lag-linaro That's great, if you make a PR please let me know
Probably, you should have opened a PR for our fork. After that, I'll accept and then "forward" the PR for the master project. Sorry for not being too clear.
Please, close the PR and open a new one for our fork project. Thanls
Ah yes, I can do that. Would you mind rebasing it though please?
"This branch is 2 commits ahead, 157 commits behind docker-library:master."
Looks like you still have 2 commits which are yet to be merged too?
Oh yes, you're right!
Please for this project instead, which is currently synched.
It doesn't appear to be working screenshot
Would you be kind enough to explain why the patches need to be routed by your tree please?
It's more common to submit directly to the upstream repo.
Not very expert actually. Anyway, I'll do the required change from my project. Please remove your previous PR and, once done, I'll open the same PR.
So the easiest thing for you to do is:
git remote add lag-linaro https://github.com/lag-linaro/official-images.git
git fetch lag-linaro
git cherry-pick lag-linaro/lightstreamer-enable-arm64v8
Then push the result to your own Official Images repos and send the PR from there.
Thanks!
https://github.com/docker-library/official-images/pull/4576
Would you mind closing the previuos one? (if possible)
Closed. Thanks.
Hi,
would you mind privately writing to me to show us your interest in Lightstreamer technology?
Thanks and Regards.
I was build this image on arm64 architecture and successed ,So I want to know can we add it to the https://hub.docker.com/u/arm64v8/ ?