search

Lightstreamer / Docker

Docker Official Image packaging for Lightstreamer Server https://www.lightstreamer.com
Apache License 2.0
3 stars 2 forks source link

support arm64 architecture #2

Open longquan7 opened 6 years ago

longquan7 commented 6 years ago

I was build this image on arm64 architecture and successed ,So I want to know can we add it to the https://hub.docker.com/u/arm64v8/ ?

gfinocchiaro commented 6 years ago

As far as I know, to make it available from https://hub.docker.com/u/arm64v8/ it is required to update the official definition file, but we'll do that in the next few weeks when Lightstreamer 7 will be officially released.

lag-linaro commented 6 years ago

@gfinocchiaro we have managed to build and run Lightstreamer on ARM64v8 with no issues.

Would it be okay to enable this project so that it's docker pullable on our systems please?

If you need help, I would be happy to provide a Pull Request for you.

gfinocchiaro commented 6 years ago

Hi,

do you have a link from which I can view the definition file?

lag-linaro commented 6 years ago

THIS is the file that needs changing.

Again, I'm happy to do it for you if you'd support it.

gfinocchiaro commented 6 years ago

Ok, thanks. Does the Dockerfile needs any specific update?

lag-linaro commented 6 years ago

The current Dockerfile 'just worked' on our ARM64v8 platform.

No other changes are required to support it.

gfinocchiaro commented 6 years ago

May I ask you for which kind of devices are you planning to run the Lightstreamer Docker image?

lag-linaro commented 6 years ago

I am currently testing it on an Enterprise level (64-cores, 256GB RAM, etc) platform.

gfinocchiaro commented 6 years ago

Ok, feel free to make a PR.

lag-linaro commented 6 years ago

Okay, all done. Please feel free to review and/or provide your Ack.

https://github.com/docker-library/official-images/pull/4570

longquan7 commented 6 years ago

@lag-linaro That's great, if you make a PR please let me know

gfinocchiaro commented 6 years ago

Probably, you should have opened a PR for our fork. After that, I'll accept and then "forward" the PR for the master project. Sorry for not being too clear.

Please, close the PR and open a new one for our fork project. Thanls

lag-linaro commented 6 years ago

Ah yes, I can do that. Would you mind rebasing it though please?

"This branch is 2 commits ahead, 157 commits behind docker-library:master."

Looks like you still have 2 commits which are yet to be merged too?

gfinocchiaro commented 6 years ago

Oh yes, you're right!

Please for this project instead, which is currently synched.

lag-linaro commented 6 years ago

It doesn't appear to be working screenshot

lag-linaro commented 6 years ago

Would you be kind enough to explain why the patches need to be routed by your tree please?

It's more common to submit directly to the upstream repo.

gfinocchiaro commented 6 years ago

Not very expert actually. Anyway, I'll do the required change from my project. Please remove your previous PR and, once done, I'll open the same PR.

lag-linaro commented 6 years ago

So the easiest thing for you to do is:

git remote add lag-linaro https://github.com/lag-linaro/official-images.git git fetch lag-linaro git cherry-pick lag-linaro/lightstreamer-enable-arm64v8

Then push the result to your own Official Images repos and send the PR from there.

gfinocchiaro commented 6 years ago

Thanks!

https://github.com/docker-library/official-images/pull/4576

Would you mind closing the previuos one? (if possible)

lag-linaro commented 6 years ago

Closed. Thanks.

gfinocchiaro commented 6 years ago

Hi,

would you mind privately writing to me to show us your interest in Lightstreamer technology?

Thanks and Regards.