search

Lighttree / react-reactions

0 stars 0 forks source link

Feedback on Reakit #2

Open diegohaz opened 5 years ago

diegohaz commented 5 years ago

Hey @Lighttree

I'm following public repositories that use Reakit, including this one. I saw that you removed it from the project (which is totally fine 😊).

I'm constantly trying to improve the library, and I think your feedback would be really valuable.

Which problems did you have with Reakit? How could it be better for you? What do you think Material UI does better?

Thank you 🙏

Lighttree commented 5 years ago

Hi :)

Sure, but keep in mind that I used only popover and tooltip and this was my first PoC using React. So I assume I can miss something.

I had some issues when wrapped my custom component in TooltipReference, as far as I got it expects reference to be element like <button> or something native. But I needed my custom component to be a reference. It was working actually, but there was bug with positioning in my particular example. I had number of ReactionGroup elements in a row, each of them wrapped in TooltipReference and Tooltip appeared above last item in the list for any of them (it changed info inside, but not position).

Another one was I think on my side due to lack of experience with hooks. I didn't get how to make popover in "Controllable" way without reference component. Because I wanted to interact with it from different parts of component tree. I guess useTooltipState should solve this, but as far as I remember I had some issues with it.

When I rendered https://github.com/missive/emoji-mart inside popover this combination caused force re-render. Which disappear as soon as I changed popover. Unfortunately I had no time to investigate what was wrong, due to limited time.