LilasCorner / jlootbox

Other
1 stars 0 forks source link

Consider revising 'validate' to be static, use separate methods for different kinds of validation #13

Open JohnTMurphy-NIU opened 2 years ago

JohnTMurphy-NIU commented 2 years ago

The 'validate' methods in JLootboxBuilder can be static (they do not use instance variables). You should also consider creating separate methods to validate even/odd and square root instead of passing values as flags- someday you may need to test for those values!