Lootbox methods generateRarity() and generateBias() should be private static (probably?)

LilasCorner / jlootbox

Other

1 stars 0 forks source link

Lootbox methods generateRarity() and generateBias() should be private static (probably?) #7

Open JohnTMurphy-NIU opened 2 years ago

JohnTMurphy-NIU commented 2 years ago

Consider whether these two methods are actually functionality that an instance has or whether they are functions of the class in general. Are any instance variables used? Also consider whether they should be public or private. Do they need to expose the functionality to other classes?