LilithHafner / UpdateJulia.jl

Simple cross platform Julia installer
GNU General Public License v3.0
59 stars 3 forks source link

update install location & add systemwide option #12

Closed LilithHafner closed 2 years ago

LilithHafner commented 2 years ago

fixes #7

codecov-commenter commented 2 years ago

Codecov Report

Merging #12 (dbe90e6) into main (08ab856) will decrease coverage by 2.72%. The diff coverage is 81.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   84.37%   81.64%   -2.73%     
==========================================
  Files           1        1              
  Lines         128      158      +30     
==========================================
+ Hits          108      129      +21     
- Misses         20       29       +9     
Impacted Files Coverage Δ
src/UpdateJulia.jl 81.64% <81.63%> (-2.73%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08ab856...dbe90e6. Read the comment docs.

LilithHafner commented 2 years ago

This PR was complicated by the fact that install_location and default_install_location expand the scope of testing to include

LilithHafner commented 2 years ago

The issue was passing an invalid set_default=true keyword argument on windows, we now gracefully ignore that argument with a warning.

LilithHafner commented 2 years ago

Need to document this behavior!