search

LilithHafner / UpdateJulia.jl

Simple cross platform Julia installer
GNU General Public License v3.0
59 stars 3 forks source link

Fix typos in README.md #28

Closed PallHaraldsson closed 9 months ago

PallHaraldsson commented 1 year ago

[skip ci]

codecov-commenter commented 1 year ago

Codecov Report

Merging #28 (fc3ca11) into main (c518a22) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files           1        1           
  Lines         203      203           
=======================================
  Hits          181      181           
  Misses         22       22

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

PallHaraldsson commented 1 year ago

About:

Please also consider using JuliaUp, especially for Windows. [..] Note: this is a julia package

Maybe you have julia lower-case intentionally (in some cases), for the binary. I think it would be ok to always go with upper, e.g. also Juliaup, even though its binary is is lower-cased. But JuliaUp with Up may not be wanted/official. On "especially for Windows" You can go with it (now) in all cases, and likely should. I guess you meant, then not my package... when is it really better? I didn't know of it. I always use juliaup now, also usually when benchmarking, unless I'm really concerned about tine slower startup...

LilithHafner commented 9 months ago

This has gone stale, the typos have been fixed already, and this still contians buggy changes to the example output in the readme.