search

Lily-Technologies / lily-wallet

The best way to secure your bitcoin.
https://lily-wallet.com
Other
94 stars 15 forks source link

send the '--testnet' param to HWI when using a testnet wallet #34

Closed djpnewton closed 4 years ago

djpnewton commented 4 years ago

I missed this earlier

djpnewton commented 4 years ago

@KayBeSee I think this is important for hardware wallets to work when in testnet mode

KayBeSee commented 4 years ago

Can you link to some documentation in HWI? What exactly does this flag do?

djpnewton commented 4 years ago

There is not much documentation: https://github.com/bitcoin-core/HWI/blob/2b8102e06a094bc150bcbd4b233819f350e44c9e/hwilib/cli.py#L124

It changes the type of xpub retrieved from the device (xpub vs tpub), I assume it changes the type of address returned by 'displayaddress'

Maybe it is not required for 'signtx'

KayBeSee commented 4 years ago

Interesting. Ok, merged.