Lily-Technologies / lily-wallet

The best way to secure your bitcoin.
https://lily-wallet.com
Other
94 stars 15 forks source link

Transaction / UTXO Labeling #59

Closed KayBeSee closed 2 years ago

KayBeSee commented 3 years ago

Be able to add labels to UTXOs / Transactions.

Related to #58 and #38 since labels will be saved to a file.

KayBeSee commented 2 years ago

Address labeling added via 64ca20e6b5f030745bd0e8b087edd16036905f4c

KayBeSee commented 2 years ago

Thinking through this ticket a bit more and realizing that tagging transactions / utxos specifically seems unnecessary. Everything really revolves around addresses -> transactions -> UTXOs.

I'm starting to think that tagging individual UTXOs is a bad idea and should rely on pulling tags from the address and transaction the UTXO was sent to / sent in.

If we are going to tag a UTXO "KYC" or "Swan" or "CashApp" or "Non KYC", then those same tags would apply to the transaction or address

i.e.

I send bitcoin to CashApp, tag the transaction as "CashApp" and "KYC" and then that label should be applied to my change address too.

If I receive bitcoin from Swan, I should have that address already tagged as "Swan" and "KYC" but if I don't, I can add that in the transaction tag field.

In fact, even transactions shouldn't really have tags associated with them directly since transactions are just made up of money going to/from addresses.

So the retrieval logic should go through all inputs/outputs and look up tags based on address and then display them in transaction details.

KayBeSee commented 2 years ago

This is nearly complete.

I added:

You can also search UTXOs and Addresses in the Settings page.

I think the last item to include is search on the transactions view and then this can be closed out.