LilyDaytoy / OpenPVSG

Benchmarking Panoptic Video Scene Graph Generation (PVSG), CVPR'23
https://jingkang50.github.io/PVSG/
Other
77 stars 5 forks source link

There is something wrong with your code when I execute test_relation_full.sh. #14

Open XiaoyiHan6 opened 3 months ago

XiaoyiHan6 commented 3 months ago

Hello Dr. Yang Your original code test_relation_full.sh

# sh scripts/test/test_relation_full.sh
PARTITION=priority
JOB_NAME=psg
PORT=${PORT:-$((29500 + $RANDOM % 29))}
GPUS_PER_NODE=${GPUS_PER_NODE:-1}
CPUS_PER_TASK=${CPUS_PER_TASK:-5}

PYTHONPATH="/mnt/lustre/jkyang/CVPR23/openpvsg":$PYTHONPATH \
srun -p ${PARTITION} \
    --job-name=${JOB_NAME} \
    --gres=gpu:${GPUS_PER_NODE} \
    --ntasks-per-node=${GPUS_PER_NODE} \
    --cpus-per-task=${CPUS_PER_TASK} \
    --kill-on-bad-exit=1 \
    python tools/rel_test_full.py --launcher="slurm" ${PY_ARGS}

The code is incorrect, because your tools/rel_test_full.py doesn't even have an argument for args.launcher. And This is an error message.

+ srun -p priority --job-name=psg --gres=gpu:1 --ntasks-per-node=1 --cpus-per-task=5 --kill-on-bad-exit=1 python tools/rel_test_full.py --launcher=slurm
usage: rel_test_full.py [-h] [--work-dir WORK_DIR] [--model-pth MODEL_PTH]
rel_test_full.py: error: unrecognized arguments: --launcher=slurm
srun: error: g0008: task 0: Exited with exit code 2
srun: launch/slurm: _step_signal: Terminating StepId=1141480.0

your original code tools/rel_test_full.py

...
parser = argparse.ArgumentParser(description='prepare relation set')
parser.add_argument('--work-dir', help='vanilla, filter, conv, transformer')
parser.add_argument('--epoch-id', type=int, default='100')
args = parser.parse_args()
....

So, when we execute test_relation_full.sh, we should delete this argument --launcher="slurm"


I wrote this issue to tell anyone who executes this code to be aware of this bug.

Sincerely, XY.Han

leaozhun commented 1 day ago

你好,请问这里的work_dir参数是如何定义的呢