LilyDaytoy / pe

0 stars 0 forks source link

Unclear tip in UG #10

Open LilyDaytoy opened 2 years ago

LilyDaytoy commented 2 years ago

截屏2021-11-12 下午5.26.06.png

In UG it says if the given date is invalid, it will be rounded down, but only when the invalid date is 1 greater than the boundary, it will be rounded down to a correct one, so it might be better to say "If the user mistakenly thinks the month has 31 days, the date he or she entered will be counted down"

nus-se-bot commented 2 years ago

Team's Response

The program rounds down as long as the day is between 1 and 31. For instance, 2021-02-31 will be rounded down to 2021-02-28, thus it is not only when it is 1 greater than the boundary. The first point is telling that any number not between 1 to 31 will be invalid. However, second point is saying that we give the users the benefit of the doubt that they may not know that 31st, or any day between 1-31 may not exist in that month, so we automatically help them round down because as per the first point, we consider 1-31 as valid inputs.

Thus the description is correct, concise, and serves the purpose.

Changing to low as it does not affect normal operations of the product. Appears only in very rare situations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]