search

LimHongYao / pe

0 stars 0 forks source link

Empty module list prints double line #2

Open LimHongYao opened 1 year ago

LimHongYao commented 1 year ago

Extra line was accidentally printed for the empty module list, compared to typical commands

/remove SNU/1
[M2794.0022][Applied Thermodynamics][3]   maps to ----> [ME3661][Technical Elective][4]
This module has been deleted from the current module list!
____________________________________________________________
/remove SNU/1
Deletion failed :( Please check the index to be removed again
____________________________________________________________
/remove SNU/1
Deletion failed :( Please check the index to be removed again
____________________________________________________________
/list current SNU
The current module list is empty for: SEOUL NATIONAL UNIVERSITY
____________________________________________________________
____________________________________________________________
nus-se-script commented 1 year ago

Team's Response

The list commands in the program are meant to have two lines printed.

An example is given here for /list current ku

image.png

This distinction for list commands was made as the list commands are rather unique in our program as the number of lines it prints out are higher than the other commands, hence two lines were used to let users know where the start and end of the list is.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Understood that the general implementation of /list current KU will require two lines in typical use to distinguish the start and end of the list.

However, output in this case clearly states that the module list is empty, and a different message was printed out in place of an empty list, thus I see no need to print two lines. Pardon for harshness, but roughly speaking, no need to define the start and end of an empty list.

This issue is also largely a cosmetic issue, hence the very low severity. I suppose it can be said that it could cause some confusion if the dev team had to debug something related, but I assume they are familiar with the program behavior and therefore it should not cause an issue.