Closed james-yoo closed 1 year ago
Hi @LimHyungTae, Thanks for releasing the great work! I found that there are magic numbers in the code that can be effected the final extraction result as follow. 1) Could you please explain linearity? https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L460 2) Should I use a value larger than the sensor's mounting height? https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L525 3) What is the meaning of the size of the point cloud? https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L283
ping @LimHyungTae,
True:
Great. Thanks!
Hi @LimHyungTae, Thanks for releasing the great work! I found that there are magic numbers in the code that can be effected the final extraction result as follow. 1) Could you please explain linearity? https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L460 2) Should I use a value larger than the sensor's mounting height? https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L525 3) What is the meaning of the size of the point cloud? https://github.com/LimHyungTae/patchwork/blob/93b493cb57d205dc3564229fd3f9d35977f39ecd/include/patchwork/patchwork.hpp#L283