Closed Zurcusa closed 3 months ago
I see the WasmCustomSection
record previously used as a DTO for the API of WasmSectionUtils
is no longer used. If you deem that the newly imported dependency chicory
renders the old API obsolete, then I'd also remove WasmCustomSection
. Seems to me that this is the case.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Description
Switch to dynamically loading the memory import from the provided wasm files. Also removes the manual parsing logic for the custom sections.
What does this PR do? Loads the memory import dynamically from the provided runtime wasm. Further Improves the custom section parsing.
Why are these changes needed? Defining a static memory import causes runtime init failure when the runtimes change their minimum memory limits.
How were these changes implemented and what do they affect? They're implemented with the help of this parser.. The memory import is extracted before the initialization of the runtime instance and loaded in its imports.
Fixes #445
Checklist: