search

LimeChain / etherlime

Dapp Development framework based on ethers.js
MIT License
185 stars 41 forks source link

etherlime compile and deploy aren't failing correctly #306

Open elenadimitrova opened 4 years ago

elenadimitrova commented 4 years ago

etherlime compile and etherlime deploy seem to be "hiding" errors causing CI service to think failing steps have passed. Sample green builds below for

Bad etherlime compile - see step "Compiling contracts" https://circleci.com/gh/argentlabs/argent-contracts/77

Bad etherlime deploy - see step "Testing deployment scripts" and search for Your deployment script finished with failure! https://circleci.com/gh/argentlabs/argent-contracts/78

EDIT: This is not the case with etherlime test which does fail correctly, example build https://circleci.com/gh/argentlabs/argent-contracts/56

EDIT: I just came upon an example where even etherlime test reports a false positive https://circleci.com/gh/argentlabs/argent-contracts/97

ochikov commented 4 years ago

Thank you for the issue. We are going to investigate it.

elenadimitrova commented 4 years ago

Investigating a bit more it appears you are not throwing an error on compilation errors but just putting the error on the stack and rejecting the compilation promise.

ochikov commented 4 years ago

Thank you. I will investigate it as well and fix it in the next releases.

elenadimitrova commented 4 years ago

Unfortunately due to this we managed to merge some changes that broke our development branch https://circleci.com/gh/argentlabs/argent-contracts/1238 :(