LimeChain / hashport-validator

Official repository containing the source code of the Hashport validators
Apache License 2.0
23 stars 11 forks source link

Second verification of fee sent with prev calculated hbar price #805

Closed trayanm closed 1 year ago

trayanm commented 1 year ago

Add function in transfer watcher to handle fee sent verification Add functionality in pricing service to store prev calculated nft fee

Signed-off-by: Trayan Manolov trayan.manolov@limechain.tech

Detailed description:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #805 (688a477) into main (5560a30) will increase coverage by 0.50%. The diff coverage is 82.97%.

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   62.56%   63.07%   +0.50%     
==========================================
  Files          87       87              
  Lines        6465     6491      +26     
==========================================
+ Hits         4045     4094      +49     
+ Misses       2224     2201      -23     
  Partials      196      196              
Flag Coverage Δ
unittests 63.07% <82.97%> (+0.50%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/process/watcher/transfer/watcher.go 52.66% <79.48%> (+6.92%) :arrow_up:
app/services/pricing/service.go 74.79% <100.00%> (+3.97%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.