LimeChain / hashport-validator

Official repository containing the source code of the Hashport validators
Apache License 2.0
23 stars 11 forks source link

Added tranaction drop in awaitTransfer() loop #812

Closed Coiling-Dragon closed 1 year ago

Coiling-Dragon commented 1 year ago

Signed-off-by: Stanislav Viyachev stanislav.viyachev@limechain.tech

Detailed description: Fixes: Endless loop with "Transfer not yet added. Querying after 5 seconds" by dropping the transaction. Errors associated with transaction drop:

ERRO[2023-01-10T13:28:41.068114+02:00] [0.0.18636873-1665042530-993261056] - Failed to await incoming transfer and its fee. Error: [[0.0.18636873-1665042530-993261056] - Failed to retrieve Transaction Record, dropping transaction]  context="Messages Service"
ERRO[2023-01-10T13:28:41.068156+02:00] [0.0.18636873-1665042530-993261056] - Failed to perform sanity check on incoming signature [ec8a7b41aeb9fb315873c99e606a56b83cb387970997f166b17a911c66e7c6dc4db3baa3901b676cc072e4e63379b36ec860a9ac5724c5c1b0102020dc5977cf1b].  context="Topic [0.0.48224069] Handler"

Which issue(s) this PR fixes: Fixes #810

Special notes for your reviewer:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #812 (11e1f8e) into main (6608e73) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   64.28%   64.34%   +0.05%     
==========================================
  Files          88       88              
  Lines        6717     6722       +5     
==========================================
+ Hits         4318     4325       +7     
+ Misses       2180     2178       -2     
  Partials      219      219              
Flag Coverage Δ
unittests 64.34% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/services/messages/service.go 66.66% <100.00%> (+1.62%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.