LimeChain / hashport-validator

Official repository containing the source code of the Hashport validators
Apache License 2.0
23 stars 11 forks source link

fix a bug in lock-events service - status channel hanging #849

Closed Coiling-Dragon closed 1 year ago

Coiling-Dragon commented 1 year ago

Detailed description: Fixes bigs in lock-event flows ( status channel was hanging on failed transactions )

Which issue(s) this PR fixes: Fixes #831

Special notes for your reviewer:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #849 (41a5741) into main (5023bc7) will decrease coverage by 0.08%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   64.34%   64.26%   -0.08%     
==========================================
  Files          88       88              
  Lines        6723     6731       +8     
==========================================
  Hits         4326     4326              
- Misses       2178     2186       +8     
  Partials      219      219              
Flag Coverage Δ
unittests 64.26% <0.00%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/services/lock-event/service.go 13.36% <0.00%> (-0.60%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.