LimeChain / hashport-validator

Official repository containing the source code of the Hashport validators
Apache License 2.0
23 stars 11 forks source link

Fee per user fixes #870

Closed rokn closed 1 year ago

rokn commented 1 year ago

Detailed description: Fixes read only not calculating with fee policies. Fixes burn event not being handled

Special notes for your reviewer: I've added the fee policy service in the fee calculator so now only the fee calculator is used.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #870 (e7b77c9) into main (1983b87) will decrease coverage by 0.06%. The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   64.19%   64.13%   -0.06%     
==========================================
  Files          88       88              
  Lines        6787     6798      +11     
==========================================
+ Hits         4357     4360       +3     
- Misses       2209     2216       +7     
- Partials      221      222       +1     
Flag Coverage Δ
unittests 64.13% <55.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../process/handler/read-only/fee-transfer/handler.go 17.10% <0.00%> (ø)
app/services/fee/calculator/calculator.go 58.69% <42.85%> (-10.75%) :arrow_down:
...edera/mirror-node/model/transaction/transaction.go 100.00% <100.00%> (ø)
app/process/handler/read-only/fee/handler.go 42.85% <100.00%> (ø)
app/services/burn-event/service.go 69.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rokn commented 1 year ago

Closing this as it's part of #877