LimeChain / hashport-validator

Official repository containing the source code of the Hashport validators
Apache License 2.0
23 stars 11 forks source link

Fix pricing service lock on update #872

Closed rokn closed 1 year ago

rokn commented 1 year ago

Detailed description: The pricing service was going into a locked state when an update is taking too long. This was because the mutex-es were locked at the start instead when needed.

Special notes for your reviewer:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #872 (667a018) into main (1983b87) will increase coverage by 0.17%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   64.19%   64.37%   +0.17%     
==========================================
  Files          88       88              
  Lines        6787     6807      +20     
==========================================
+ Hits         4357     4382      +25     
+ Misses       2209     2204       -5     
  Partials      221      221              
Flag Coverage Δ
unittests 64.37% <100.00%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/services/pricing/service.go 77.42% <100.00%> (+2.63%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.