LimeChain / hashport-validator

Official repository containing the source code of the Hashport validators
Apache License 2.0
23 stars 11 forks source link

Fix pricing service lock on update (#872) #873

Closed rokn closed 1 year ago

rokn commented 1 year ago

Detailed description:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #873 (a15aa79) into testnet (5849e91) will increase coverage by 0.12%. The diff coverage is 100.00%.

:exclamation: Current head a15aa79 differs from pull request most recent head 07ea632. Consider uploading reports for the commit 07ea632 to get more accurate results

@@             Coverage Diff             @@
##           testnet     #873      +/-   ##
===========================================
+ Coverage    61.94%   62.06%   +0.12%     
===========================================
  Files           81       81              
  Lines         6183     6203      +20     
===========================================
+ Hits          3830     3850      +20     
+ Misses        2171     2170       -1     
- Partials       182      183       +1     
Flag Coverage Δ
unittests 62.06% <100.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/services/pricing/service.go 77.42% <100.00%> (+2.63%) :arrow_up:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.