search

Limenius / Liform

PHP library to render Symfony Forms to JSON Schema
MIT License
138 stars 75 forks source link

PHP8 Compatibility #57

Closed phpwutz closed 1 year ago

phpwutz commented 3 years ago

Hi there! Thanks for maintaining the package so far. I created this PR to get it compatible with PHP8. PHPUnit tests ran fine with this setup, I hope its of use. best regards

pixlmint commented 3 years ago

Would fix #56

pixlmint commented 3 years ago

@nacmartin How's it looking? Have you had time to look into this yet?

phpwutz commented 3 years ago

I've just contacted the official maintainer. after all it's already been almost 4 month. will post updates here

nacmartin commented 2 years ago

@phpwutz I answered your email, did you receive it?

jandlouhy commented 2 years ago

Hi! Any updates?

florent-izypay commented 2 years ago

Hi,

This would be great to have a php 8.0 migration path with this lib. It is the last piece of code preventing me from dropping php 7. May we know if there is a plan to merge this PR ?

jackthomasatl commented 2 years ago

Yea. This is holding me up on being able to use this project. Can this PLEASE get merged now? Who is the maintainer?

jackthomasatl commented 2 years ago

@nacmartin How's it going?

reypm commented 2 years ago

@nacmartin yea I am using this too and is holding me up with my PHP8 migration, any updates on this merge?

pnovales commented 2 years ago

Any plan soon to get this PR merge in?

umpirsky commented 2 years ago

@phpwutz I guess no updates? :)

llupa commented 1 year ago

Will this ever be merged? Is the bundle dead?

umpirsky commented 1 year ago

It is, RIP.

phpwutz commented 1 year ago

oh hey everyone. so the current state that i'm aware of is that neither me nor the original maintainer have the resources to maintain this project. as far as i understood the original maintainer is happy to hand over the project to anyone who wants to maintain it

umpirsky commented 1 year ago

Can you just merge this PR? I can do it if you give me access. Thanks.

nacmartin commented 1 year ago

Merged, sorry and thanks for the work

umpirsky commented 1 year ago

Thanks, but we need this to be able to update.

nacmartin commented 1 year ago

Thanks, but we need this to be able to update.

Done

umpirsky commented 1 year ago

Thanks!

My bad, looks like that was not enough:

  Problem 1
    - Root composer.json requires limenius/liform-bundle ^0.18 -> satisfiable by limenius/liform-bundle[v0.18.0].
    - limenius/liform-bundle v0.18.0 requires limenius/liform ^0.17 -> found limenius/liform[v0.17.0] but it conflicts with your root composer.json require (^0.18).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Looks like we need "limenius/liform": "^0.17|^0.18" https://github.com/Limenius/LiformBundle/pull/33

nacmartin commented 1 year ago

I see, I think we can do with the bundle in v0.18 requiring liform (the library) v0.18. Makes things simpler.

nacmartin commented 1 year ago

Done. (LiformBundle v0.18.1) Try it please!

umpirsky commented 1 year ago

Works great, thanks!