search

Limenius / LiformBundle

Symfony Bundle to render Symfony Forms to JSON Schema
MIT License
138 stars 44 forks source link

FormType time should not use StringTransformer by default #28

Closed laurent-bientz closed 1 year ago

laurent-bientz commented 3 years ago

Hello @nacmartin ,

By default, you specify StringTransformer as the default transformer for TimeType in transformers.xml.

With this default settings, it's just impossible to override the TimeType with another Transformer, for example if we want to use a ChoiceType (select input) with the 'choice' widget.

It's possible to remove this default settings?

Thanks in advance

laurent-bientz commented 3 years ago

Same for PercentType forced as string, we can't override this on integer if type is integer

Same for MoneyType. If divisor is set to 100, should be a number, not a string.

laurent-bientz commented 1 year ago

lol nice spirit to delete my comment on an issue opened more than 2 years ago without any response.

I can perfectly understand that you don't have the time or the inclination to maintain this project but to delete a comment that promote an alternative to your abandonned project 😑

nacmartin commented 1 year ago

Hi @laurent-bientz. You left this morning three comments on three issues linking to your project. That project is by the way, basically following the same idea of this one, using the same ideas (resolver, reducers...) without a single courtesy mention like "this is inspired by Liform". It is ok, I have preserved one of these three comments, but I don't see the need to have three of them. There are also other forks, and other people have said "here, use this fork", and the comments are there. But I think that one comment per project is ok, no need to outspam the other alternatives.

laurent-bientz commented 1 year ago

Hi @nacmartin,

First it's not a fork and nothing on this bundle is based on your work, transformer it's just a common word to basically "transform", so yes, to get a schema from a form, it's what we do.

Second, I just commented my issues if other people are having the same pb, which no one has answered for over 2 years and are still open.

Once again, no problem with the fact that you don't want to spend any more time on this solution, it is for this reason that we have redeveloped a new bundle from scratch, you could just inform people that your solution is abandoned.

And to be fair, you let my comment on an issue that you closed immediatly just after and receiving a notification for "deleting a comment" after no activity since issue creation is just weird.

Whatever it's ok, the goal was not to steal something from you, it's just we didn't find any alternative to your bundle excepts many forks that don't resolve the base problem, it was just to inform people interested by you bundle that they can take a look if they want.

Take care.

nacmartin commented 1 year ago

As you say, you have redeveloped this after not finding alternatives to it. Nothing stops you from doing it, or from using the code if you wish. After all, of this has MIT license. But it is a nice touch to say "This is inspired by X", as courtesy, given that you expect courtesy. Anyways, best wishes.