Limenius / ReactBundle

Client and Server-side React.js rendering in a Symfony Bundle
MIT License
390 stars 53 forks source link

Fix incompatibility with react-on-rails npm package #20

Closed teameh closed 7 years ago

teameh commented 7 years ago

react-on-rails moved away from hidden divs..

Use <script type="application/json"> for props and store instead of hidden div #775

this bundle needs to be updated as well..

(I might be able to work on this next week if you like)

teameh commented 7 years ago

~(I might be able to work on this next week if you like)~ working on a proposal now.

teameh commented 7 years ago

Haha oh sorry, I wasn't aware of the separation of the renderer into its own package. Made a PR here https://github.com/Limenius/ReactRenderer/pull/1

nacmartin commented 7 years ago

Thanks! included in v0.12.0