search

Limit-Theory-Redux / ltheory

Limit Theory Redux is a fork of the discontinued open-world space simulation game Limit Theory. We have made it our mission to continue the development of the ambitious Limit Theory project as an open source initiative.
Apache License 2.0
62 stars 8 forks source link

Reformat imports, enforce formatting for PRs. #315

Closed dgavedissian closed 4 months ago

dgavedissian commented 4 months ago

I've noticed a few times a PR gets merged, then a cargo fmt in another PR updates the formatting of previously merged PRs.

To prevent this, I've added an additional linting CI step that runs before anything else to check this before we run CI.

As part of this PR, I also introduced a .rustfmt.toml file. It includes these unstable features:

imports_granularity = "Module"
group_imports = "StdExternalCrate"

I've commented them out, to prevent warnings when running the stable cargo fmt, but I decided to run cargo +nightly fmt with these options enabled, which significantly tidied up our imports.