search

LimnoTech / HSPsquared

Hydrologic Simulation Program Python (HSPsquared)
GNU Affero General Public License v3.0
2 stars 0 forks source link

Merge develop-WaterQuality-BC into develop #19

Closed aufdenkampe closed 3 years ago

aufdenkampe commented 3 years ago

Similar to PR #18, I'm going to merge the develop-WaterQuality-BC branch into develop to simplify our management of the repo and fold in the GLWACSO test cases from @bcous. This will allow us to more easily use those files in our development.

As with #18, I'll use this PR to look for specific commits to cherry-pick. Then I'll delete this branch.

CC: @steveskrip & @bcous

aufdenkampe commented 3 years ago

I might hold off on merging this because of the 1.3 GB of files in the GLWACSO directory. It might make sense to first think through how we might leverage Github's Large File Storage (LFS) system. @steveskrip already ran into a need for this, because of the 100 MB per file limit.

Digesting this article is a place to start: https://docs.github.com/en/github/managing-large-files/working-with-large-files

aufdenkampe commented 3 years ago

Closing this PR, as we do not want to directly merge the very large GLWACSO test files into the develop branch. Rather, we'll get these files in once we implement: Use GitHub's Large File Storage (LFS) for model files #26